Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(FEC-13664): Add the ability to configure default alignment of captions on the player # #769

Merged
merged 13 commits into from
Mar 18, 2024

Conversation

semarche-kaltura
Copy link
Contributor

Description of the Changes

  1. Add textAlign: string (left/right/center) property to config.text.textStyle;
  2. Remove align option form config.text.textTrackDisplaySetting;
  3. Remove forceCenter option from config.text
  4. upd documentation;
  5. handle caption alignment based on config.text.textStyle.textAlign configuration;
  6. upd tests;
image

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

@SivanA-Kaltura
Copy link
Contributor

@semarche-kaltura If someone has an existing configuration for captions, will it still work after this change ?

docs/configuration.md Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
src/player.ts Outdated Show resolved Hide resolved
SivanA-Kaltura
SivanA-Kaltura previously approved these changes Mar 5, 2024
src/player.ts Outdated Show resolved Hide resolved
src/engines/html5/html5.ts Outdated Show resolved Hide resolved
src/types/interfaces/engine.ts Outdated Show resolved Hide resolved
@semarche-kaltura semarche-kaltura merged commit cb0ba18 into master Mar 18, 2024
11 checks passed
semarche-kaltura pushed a commit that referenced this pull request Mar 27, 2024
…nt of captions on the player # (#769)"

This reverts commit cb0ba18.
semarche-kaltura pushed a commit that referenced this pull request Apr 1, 2024
… alignment of captions on the player # (#769)""

This reverts commit 2b7fd11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants