-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-13664): Add the ability to configure default alignment of captions on the player # #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semarche-kaltura
requested review from
MosheMaorKaltura,
JonathanTGold,
lianbenjamin and
SivanA-Kaltura
February 26, 2024 11:38
@semarche-kaltura If someone has an existing configuration for captions, will it still work after this change ? |
SivanA-Kaltura
requested changes
Feb 28, 2024
SivanA-Kaltura
previously approved these changes
Mar 5, 2024
SivanA-Kaltura
requested changes
Mar 12, 2024
SivanA-Kaltura
requested changes
Mar 13, 2024
SivanA-Kaltura
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
textAlign
: string (left/right/center) property toconfig.text.textStyle
;align
option formconfig.text.textTrackDisplaySetting
;forceCenter
option fromconfig.text
config.text.textStyle.textAlign
configuration;CheckLists